Skip to content

Skip non-project containers in Repository#project

Markus Koller requested to merge repository-non-project-containers into master

What does this MR do?

This MR makes sure that we always get a Project when accessing Repository#project, or nil if the container is something else.

This shouldn't break anything because currently the container is always a project or a snippet (which are special-cased to return the project for project snippets), but this will protect against any hidden bugs with group wikis.

Ref: #211360 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports