Remove spacing interval between soft deleted projects
What does this MR do?
Fixes an issue whereby the cron job that finds soft deleted projects to remove puts too much space between the jobs and causes them to not potentially run for days, weeks or even months in extreme cases.
The cron worker that finds projects scheduled for delection adds an artifical spacing between jobs. This increases exponentially with each project scheduled for deletion.
The table below shows how long it would take the last project picked up by the cron job to execute.
| Last deletion starts after | |
|---|---|
| 5 projects | 25 minutes |
| 100 projects | 8 hours |
| 1000 projects | 3 days |
This MR removes the responsibility to schedule the job from the application and moves it to sidekiq so that the jobs can be run as capacity allows.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Mentions #212645 (closed)