Skip to content

RUN AS-IF-FOSS: Move CI secrets json schema validation to FOSS

Krasimir Angelov requested to merge 223195-validate-ci-secrets-foss into master

What does this MR do?

With !34480 (merged) we introduced new jsonb column to store CI secrets configuration. Because this is GitLab Premium feature validation was done in EE only which caused test failure for FOSS - #223195 (closed).

This moves validation to app/models/ci/build_metadata.rb, we already had to have the json schema under app/validators/json_schemas/ anyway.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #223195 (closed)

Edited by Nick Thomas

Merge request reports