Skip to content

Geo - Schedule the repositories deletion after project removal

What does this MR do?

While removing a project, Geo leaves +deleted folder behind on secondaries. This happens because GitlabShellWorker that is responsible for deleting this folder is inside a run_after_commit callback since we don't perform any database operation this callback will never be triggered.

The changes in this MR is to schedule the repository deletion to remove the +deleted folder after we trash the repositories in EE::Projects::DestroyService#geo_replicate method.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related issues

Closes #223272 (closed)

Edited by Gabriel Mazetto

Merge request reports

Loading