Skip to content

WIP: Remove metric id from metric related mutations

Miguel Rincon requested to merge remove-dependency-on-metric-id into master

What does this MR do?

Remove metric id from metric related mutations

In the current implementation actions pass a metricId to mutations to look up the metric that should change.

This change removes an unnecessary step for looking up the metric by id and instead passed a reference directly. This change aims to make the code simpler and possibly more performant.

-37 lines total 💪

Screenshots

N/A

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports