Skip to content
Snippets Groups Projects

Fix Gitaly duration timings for conflict and search RPCs

Merged Stan Hu requested to merge sh-fix-gitaly-conflicts-service-duration into master
All threads resolved!

For many Gitaly RPCs, previously the gitaly_duration_s log timings only accounted for the initial request/response time. We now measure the total time it takes to consume the streaming response for the following RPCs:

  1. ListConflictFiles
  2. SearchFilesByContent

Part of #30334 (closed)

Edited by Stan Hu

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Oswaldo Ferreira approved this merge request

    approved this merge request

  • Oswaldo Ferreira resolved all threads

    resolved all threads

  • Oswaldo Ferreira enabled an automatic merge when the pipeline for ca023c2d succeeds

    enabled an automatic merge when the pipeline for ca023c2d succeeds

  • Thanks @stanhu, I have a single non-blocking comment at !34909 (comment 366994871). Merging for now :thumbsup:

  • mentioned in commit ba0e7fd9

  • Oswaldo Ferreira resolved all threads

    resolved all threads

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading