Fix Gitaly duration timings for conflict and search RPCs
For many Gitaly RPCs, previously the gitaly_duration_s
log timings
only accounted for the initial request/response time. We now measure the
total time it takes to consume the streaming response for the following
RPCs:
- ListConflictFiles
- SearchFilesByContent
Part of #30334 (closed)
Merge request reports
Activity
changed milestone to %13.2
added Observability groupscalability labels
1 Warning 046295d3: The commit subject length is acceptable, but please try to reduce it to 50 characters. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Etienne Baqué ( @ebaque
)Shinya Maeda ( @dosuken123
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- 046295d3 - Fix Gitaly duration timings for conflict and search RPCs
unassigned @stanhu
added backstage [DEPRECATED] label
mentioned in issue #30334 (closed)
Thanks @stanhu looks good
@oswaldo would you be up for the maintainer review? It's pretty similar to !34904 (merged)
assigned to @oswaldo and unassigned @Andysoiron
- Resolved by Oswaldo Ferreira
enabled an automatic merge when the pipeline for ca023c2d succeeds
Thanks @stanhu, I have a single non-blocking comment at !34909 (comment 366994871). Merging for now
mentioned in commit ba0e7fd9
mentioned in issue gitlab-com/gl-infra/scalability#450
added workflowcanary label
added workflowproduction label and removed workflowcanary label