Skip to content

Ensure original repository is archived after a shard move

James Fargher requested to merge fix_shard_move_archive into master

What does this MR do?

Fixes https://gitlab.com/gitlab-org/gitlab/-/issues/223128

Likely a regression caused by !32707 (merged)

Statemachine forces a new transaction for state transitions, so although calling #finish! updates the project, run_after_commit is not triggered because it is set on the "outer" transaction.

This MR adds extra tests to ensure mv_repository is run .

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by James Fargher

Merge request reports