Skip to content

Fine tune notification dot behavior

Doug Stull requested to merge 222354-adjust-notification-transitions into master

What does this MR do?

Aligns the transitions between states with the background transitions? For example before this change...

  • on click, the white border of the dot shows up sooner than the background switches to white. It's the same when I click outside the menu, the border turns to blue immediately but the background first turns to the hover state and then it disappears...
  • if I click the avatar again once the menu is open, the border of the dot remains white while the background returns to what I believe is hover state? Can we change the border to match that?

we are fixing the above items...

Screenshots

Before

dot__1_

After

Screen_Recording_2020-06-18_at_2.14.53_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #222354

Edited by Doug Stull

Merge request reports