WIP: Remove filtering pipelines by tab
What does this MR do?
This MR removes filtering pipelines by tab. The main reason for doing this is for performance and removing duplicated UI functionality. After introducing filtering pipelines with GlFilteredSearch
we are doing the exact same thing with tabs.
On production doing an API call such as pipelines.json?scope=all&page=1&username=stanhu&ref=master
responds in 7-8 seconds
. Which has a lot to do with querying count for pipelines, which will be addressed in a backend MR. Which the backend MR will not make the pipeline counts or return those in the response. Which should greatly improve the performance response times.
Related to: #219276 (closed)
Screenshots
before | after |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team