Skip to content

WIP: Remove filtering pipelines by tab

Payton Burdette requested to merge remove-filtering-pipelines-by-tab into master

What does this MR do?

This MR removes filtering pipelines by tab. The main reason for doing this is for performance and removing duplicated UI functionality. After introducing filtering pipelines with GlFilteredSearch we are doing the exact same thing with tabs.

On production doing an API call such as pipelines.json?scope=all&page=1&username=stanhu&ref=master responds in 7-8 seconds. Which has a lot to do with querying count for pipelines, which will be addressed in a backend MR. Which the backend MR will not make the pipeline counts or return those in the response. Which should greatly improve the performance response times.

Related to: #219276 (closed)

Screenshots

before after
Screen_Shot_2020-06-18_at_11.51.03_AM Screen_Shot_2020-06-18_at_11.39.17_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Payton Burdette

Merge request reports