Feature Flag should be enabled globally before it's removed from source code
What does this MR do?
Surprisingly, it seems developers remove feature flags before it's enabled globally on production server. I think this is not ideal that the feature is not tested enough to be considered as deemed stable. In fact, once I asked a person to enable a flag globally before merging an MR, and it turned out there was an underlying bug.
This MR documents a recommended practice that they should enable a flag globally on gitlab.com for at least one day, before a flag is removed from source code.
Also, when default_enabled is changed from false to true, we should enable a flag globally, otherwise gates that were added for testing purpose could interfere the option and the flag remains as partially enabled on production.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team