Skip to content

Do not register offense for drop table in down method

Mehmet Emin INAC requested to merge fix_drop_table_cop into master

What does this MR do?

There was a new Rubocop rule introduced with !34473 (merged) to restrict the usage of drop_table DSL method and DROP TABLE SQL literal usage in deployment Rails migrations. However with the initial implementation we were not checking whether the offensive code block was in down method or not. This MR allows us to use these offensive usages in down method.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #223274 (closed).

Edited by 🤖 GitLab Bot 🤖

Merge request reports