Do not register offense for drop table in down method
What does this MR do?
There was a new Rubocop rule introduced with !34473 (merged) to restrict the usage of drop_table
DSL method and DROP TABLE
SQL literal usage in deployment Rails migrations. However with the initial implementation we were not checking whether the offensive code block was in down
method or not. This MR allows us to use these offensive usages in down
method.
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides - [-] Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
- [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Closes #223274 (closed).
Edited by 🤖 GitLab Bot 🤖