Skip to content

Refine UI of integration form

What does this MR do?

Part of #197297 (closed)

Split from !33839 (closed) to reduce scope and number of changes. Please review the commits list (and description) for detailed changes.

Note: The strange-looking UI with Active / Triggers will be fixed separately in !34697 (merged). It only shows up for Service templates (which is being deprecated) and Instance-level integrations (which is unreleased).

Screenshots

Section Before After Changes
Project-level integrations Screenshot_2020-06-17_GitHub___Integrations___Settings___Gitlab_Org_Gitlab_Shell_1_ Screenshot_2020-06-17_GitHub___Integrations___Settings___Gitlab_Org_Gitlab_Shell Enter new Token help text is rendered properly
Instance-level integrations (not released yet) Screenshot_2020-06-17_Jira___Integrations___Admin_Area_1_ Screenshot_2020-06-17_Jira___Integrations___Admin_Area Width of content is limited. Sidebar is highlighted with the right section
Service templates Screenshot_2020-06-17_Jira___Service_Templates___Admin_Area_1_ Screenshot_2020-06-17_Jira___Service_Templates___Admin_Area Width of content is limited

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports