Skip to content

Replace ACE with Monaco for Blob editing/creation

Denys Mishunov requested to merge 198605-monaco-blob into master

What does this MR do?

This MR replaces ACE editor with Monaco for the creation and editing of the existing blobs. It's done in the larger effort of migrating away from ACE to Monaco and is the second step in the process (the first one was to swap the editor for Snippet edit/create form).

To test this MR:

  • in Rails console enable the :monaco_blobs feature flag
  • Go to any project and create a new file or edit an existing one
  • The editor should look more or less the same as it used to, but with more advanced syntaxis highlighting, etc. Also the page source should have monaco elements and not ACE

NOTE: The markdown toolbar (with B, I, etc. buttons) isn't the part of this MR yet and will be pushed as the second step of this effort.

This feature is not complete and is behind the feature flag. Hence no Changelog entry provided.

Screenshots

Before After
Simple file creation (Soft wrap) Screenshot_2020-06-18_at_13.59.58 Screenshot_2020-06-18_at_13.53.58
Simple file creation (Now wrap) Screenshot_2020-06-18_at_14.00.05 Screenshot_2020-06-18_at_13.54.06
Markdown file Screenshot_2020-06-18_at_14.00.26 Screenshot_2020-06-18_at_13.54.30
File from a template Screenshot_2020-06-18_at_14.00.37 Screenshot_2020-06-18_at_13.55.06

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Resolves #198605 (closed)

Edited by Denys Mishunov

Merge request reports

Loading