Replace ACE with Monaco for Blob editing/creation
What does this MR do?
This MR replaces ACE editor with Monaco for the creation and editing of the existing blobs. It's done in the larger effort of migrating away from ACE to Monaco and is the second step in the process (the first one was to swap the editor for Snippet edit/create form).
To test this MR:
- in Rails console enable the
:monaco_blobs
feature flag - Go to any project and create a new file or edit an existing one
- The editor should look more or less the same as it used to, but with more advanced syntaxis highlighting, etc. Also the page source should have monaco elements and not ACE
NOTE: The markdown toolbar (with B, I, etc. buttons) isn't the part of this MR yet and will be pushed as the second step of this effort.
Screenshots
Before | After | |
---|---|---|
Simple file creation (Soft wrap) | ||
Simple file creation (Now wrap) | ||
Markdown file | ||
File from a template |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Resolves #198605 (closed)
Edited by Denys Mishunov