Skip to content

Resolve "Explore removing dependencies on test stage"

What does this MR do?

code_quality and license_scanning run after the build stage, but did not use anything from the build stage.

So the improvements here are

  1. code_quality now will run immediately, allowing a fail fast for the static code analysis like rubocop.
  2. license_scanning which takes about 13 minutes(on internal application) will now run immediately as well, where before it only ran after the build stage.

So in essence we'll get notified earlier of static code analysis/linting issues and improve the over all CI pipeline duration time by about 8 minutes.

This time saving will lessen developer context switching due to getting feedback quicker.

Note: This has been already implemented in the version application here.

Screenshots

Snapshot of jobs above now running immediately:

Screen_Shot_2020-06-09_at_2.38.39_PM

Before snapshot of duration:

Screen_Shot_2020-06-09_at_4.25.35_PM

After snapshot of duration:

Screen_Shot_2020-06-09_at_4.25.19_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Contributes to #222358

Edited by 🤖 GitLab Bot 🤖

Merge request reports