Resolved MRs should not show suggest pipeline popup
What does this MR do?
Disabled suggest pipeline tour from showing on...
- MRs that are not open.
- There is no reason to show this when not open, it is just misleading and not a pattern we should support.
- MRs where the source branch does not exist.
- Since the guided tour's next step is to launch the web ide against the source branch, we need it to exist, else the user will experience a
404when attempting to run the tour.
- Since the guided tour's next step is to launch the web ide against the source branch, we need it to exist, else the user will experience a
Note: This feature is behind a experiment/feature flag(suggest_pipeline), so no changelog needed.
Screenshots
When source branch does not exist
| Before | After |
|---|---|
 |
 |
When merge request is not open
| Before | After |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Contributes to #222311
Edited by Doug Stull