Skip to content

Refactor identifier parsing

Alex Kalderimis requested to merge ajk-gl-identifier into master

What does this MR do?

This MR changes the parsing of GlRepository::Identifiers for clarity. It:

  • introduces subclasses to deal with the distinction between two-part and three-part formats
  • does parsing in parse instead of new
  • adds a new ArgumentError subclass

It has no functional changes, and is aimed at code clarity and maintainability.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

This MR is not intended to introduce functional changes. We have good test coverage here, and that is not changed.

/label ~backstage

Edited by Alex Kalderimis

Merge request reports