Skip to content

Clear hard failure when updating mirror via UI

Patrick Bajao requested to merge 221321-clear-hard-failure-on-force-update into master

What does this MR do?

There was a regression wherein updating a mirror that hard failed wasn't updating even when the update is triggered via web UI.

It was because the StartPullMirroringService was reseting the retry count before calling ProjectImportState#force_import_job!. As a result, the method will return and do nothing because it detects that the mirror is due to be updated and it's no longer considered as a hard failure.

To fix it, we remove the need to reset the retry count before #force_import_job! is called. The retry count will be reset in #force_import_job! once it deemed that the mirror can be force updated.

Now, we only reset the retry count when updating the next execution timestamp in the said service.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #221321 (closed)

Merge request reports