Skip to content

Use `DestroyService` when an admin deletes an SSH Key via the API

Rajendra Kadam requested to merge raju249/gitlab:services-usage-2 into master

What does this MR do?

Contributes to #220127 (closed)

We are not adding AuditEvent creation to Keys::DestroyService now as the refactoring of audit_events table is going on, and we have temporarily halted adding of new audit event types till that is complete.

This change is just a tech-debt fix, so that wherever SSH keys are destroyed across the codebase, Keys::DestroyService is used.

Once we add AuditEvent generation to this DestroyService, audit events will be recorded from all these places - that is the larger plan.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Manoj M J

Merge request reports