Skip to content

Disable task by type filters when filter bar labels are active

What does this MR do?

This MR is part of #217943 (closed), once the VSA filte bar is active, we will be able to search by label from there. If labels are selected in the filter bar, then the tasks by type chart should be updated to disable it's label search. Additionally an message should dispay to users when they hover over the label filters. This MR:

  • Adds a canSelectLabels boolean property to the type_of_work_charts.vue component
  • Adds a inactive boolean property to the labels selector
  • When inactive=true for the label selector it will:
    • Disable a message on hover in a pop up
    • Disable interaction with the label selector
    • Set the opactiy to 0.3 for the label selector

NOTE: the filter bar is behind the value_stream_analytics_filter_bar feature flag

Screenshots

no filter bar labels selected with filter bar labels
Screen_Shot_2020-06-16_at_2.09.09_am Screen_Shot_2020-06-16_at_2.10.04_am

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #217943 (closed)

Edited by Ezekiel Kigbo

Merge request reports