Skip to content

Merge security report compare services

Can Eldem requested to merge merge-compare-services into master

What does this MR do?

We use different services to compare different security reports, they are 99% the same. One bug in one of them lead us repeat the code in multiple places. This MR merges them in one single service

Before

image

After

image

Screenshots

Locally tested

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Can Eldem

Merge request reports