Skip to content

Geo Settings Form - UI

Zack Cuddy requested to merge 216134_02-add-geo-settings-fields into master

What does this MR do?

This MR is work towards #216134 (closed)

This MR is an attempt at MVC to avoid the above massive MR going in all at once.

This MR is built behind the feature flag :enable_geo_settings_form_js

This MR creates the form elements based on the mock included in the above issue.

This MR does not add any API or save actions. It strictly creates the form elements that will be used in the future MRs.

Breakdown of MRs

More information can be found here: #216134 (comment 354619867)

This is MR 2 of 5 to fully implement and replace the Geo Settings Form from HAML -> Vue

Screenshots

Desktop Mobile
before Desktop__Old_ Mobile__Old_
after Desktop__New_ Mobile__New_

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Zack Cuddy

Merge request reports