Use gl-button in MR approvals footer
What does this MR do?
Replaces GlDeprecatedButton in the MR approvals footer widget with GlButton and its associated tests. Relates to #219889 (closed)
Screenshots
| Before collapsed default | Before collapsed hover | Before expanded default | Before expanded hover |
|---|---|---|---|
 |
 |
 |
 |
| After collapsed default | After collapsed hover | After expanded default | After expanded hover |
|---|---|---|---|
 |
 |
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Taurie Davis