Update metrics dashboard favorite logic

What does this MR do?

Supports the main MR: !34115 (merged)

While working on the main MR, I noticed that usage of getters in mutations made it difficult for me to pass mock mock getters and test the mutations. So I decided to simplify the logic and eliminate the usage of getters.

After this MR, the getters is less used in 1 place and testing is easier for !34115 (merged).

Screenshots

N/A

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry
• Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers
• Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team