Skip to content

Fix user/admin group list view layout

What does this MR do?

See #220971 (closed)

There was a regression due to this MR: !32786 (merged). Specifically this line

This MR fixes the regression on the two affected views:

  • /admin/groups
  • /users/<username>/groups

As you can see in the screenshots below the line-height of the group name looks off. The line height was explicitly set and removing it could affect a number of other templates. Because of this I have created a followup issue to address this issue: #221000 (closed)

Screenshots

Page Before Regression After
/users/<username>/groups Screen_Shot_2020-06-09_at_2.23.04_PM Screen_Shot_2020-06-09_at_2.11.34_PM
/users/<username>/groups - Mobile Screen_Shot_2020-06-09_at_2.23.36_PM Screen_Shot_2020-06-09_at_2.14.03_PM
/admin/groups Screen_Shot_2020-06-09_at_2.21.30_PM Screen_Shot_2020-06-09_at_2.12.17_PM
/admin/groups - Mobile Screen_Shot_2020-06-09_at_2.22.34_PM Screen_Shot_2020-06-09_at_2.12.55_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman

Merge request reports