Fix user/admin group list view layout
What does this MR do?
See #220971 (closed)
There was a regression due to this MR: !32786 (merged). Specifically this line
This MR fixes the regression on the two affected views:
/admin/groups
/users/<username>/groups
As you can see in the screenshots below the line-height
of the group name looks off. The line height was explicitly set and removing it could affect a number of other templates. Because of this I have created a followup issue to address this issue: #221000 (closed)
Screenshots
Page | Before Regression | After |
---|---|---|
/users/<username>/groups |
![]() |
![]() |
/users/<username>/groups - Mobile |
![]() |
![]() |
/admin/groups |
![]() |
![]() |
/admin/groups - Mobile |
![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry - Not needed
-
A fix for a regression introduced and then fixed in the same release (i.e., fixing a bug introduced during a monthly release candidate) should not have a changelog entry.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
-
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team