Skip to content

Remove allow_concurrency setting

Heinrich Lee Yu requested to merge 220947-fix-boot-failure-on-unicorn into master

What does this MR do?

Gitlab::Runtime.multi_threaded? now requires access to Gitlab.config which isn't available early on in these initializers.

We don't really need this setting anyway because this just wraps the app in a mutex so that it can only be called by one thread at a time.

We're already running Puma by default so we're confident that our application works without this mutex.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #220947 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports