Ignore update_at column in audit_events table
What does this MR do?
Ignore updated_at
column in audit_events
table. We eventually would like to drop this unused column.
Followed development guideline on dropping column.
Relates to #217941 (closed)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides - [-] Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
- [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.1
removed [deprecated] Accepting merge requests label
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Mikołaj Wawrzyniak ( @mikolaj_wawrzyniak
)Igor Drozdov ( @igor.drozdov
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖added backstage [DEPRECATED] label
LGTM @tancnle , do you want me to merge it?
Before we remove the column, it might be worth to double-check that Rails behaves nicely here. In a sense,
updated_at, created_at
are "special" because Rails uses those automatically. I would expect this mechanic to play nicely with ignoring columns too, but worth a check.This shouldn't hold up the ignore-column MR at hand.
- Resolved by Andreas Brandl
assigned to @mwoolf
added workflowin review label and removed workflowin dev label
enabled an automatic merge when the pipeline for 55991aa2 succeeds
mentioned in commit 5872e6cb
added workflowstaging label and removed workflowin review label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in merge request !35690 (merged)
mentioned in merge request !35697 (merged)