Package license removal [RUN AS-IF-FOSS]
What does this MR do?
Removed package from licensing allowing any user to use the packages feature.
A few considerations:
- in some tests the description was changed to something like "without the need for a license", this was done in order to keep the indentation of the tests and avoid making the MR too confusing to review by causing too many diffs.
- as the the package code is still inside
/ee
, some places now check forGitlab.ee?
instead of the license to make sure things still work in core when/ee
is not present.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Part of #213929 (closed) Ref #221259 (closed)
Edited by Giorgenes Gelatti