Skip to content

Add API to schedule project repository storage moves

James Fargher requested to merge schedule_storage_move_api into master

What does this MR do?

#217878 (closed)

Add a new API to initiate project repository storage moves. The goal here is to give a higher visibility endpoint than the current one which is kicked off by updating projects.

Manual Testing

Assuming we have gitaly setup with a second storage called second stored in ~/Downloads/second/.

Check where the project is currently stored:

$ curl -H "PRIVATE_TOKEN: XXXX" http://localhost:3000/api/v4/projects/23
{"id":23, ... "repository_storage":"default", ...}

Initiate the move:

$ curl -X POST -H "PRIVATE_TOKEN: XXXX" -H "Content-Type: application/json" -d '{"destination_storage_name":"second"}' http://localhost:3000/api/v4/projects/23/repository_storage_moves
{"id":10,"created_at":"2020-06-09T03:25:59.474Z","state":"scheduled","source_storage_name":"default","destination_storage_name":"second","project":{"id":23,"description":"","name":"gpgme","name_with_namespace":"Administrator / gpgme","path":"gpgme","path_with_namespace":"root/gpgme","created_at":"2020-04-03T01:15:42.486Z"}}

Check the status of the move:

$ curl -H "PRIVATE_TOKEN: XXXX" http://localhost:3000/api/v4/projects/23/repository_storage_moves/10
{"id":10,"created_at":"2020-06-09T03:25:59.474Z","state":"finished","source_storage_name":"default","destination_storage_name":"second","project":{"id":23,"description":"","name":"gpgme","name_with_namespace":"Administrator / gpgme","path":"gpgme","path_with_namespace":"root/gpgme","created_at":"2020-04-03T01:15:42.486Z"}}

Double check the project has moved:

$ curl -H "PRIVATE_TOKEN: XXXX" http://localhost:3000/api/v4/projects/23
{"id":23, ... "repository_storage":"second", ...}

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mayra Cabrera

Merge request reports