Skip to content

Add gl-skeleton-loading to cluster list vue

Emily Ring requested to merge 220182-skeleton-loading into master

What does this MR do?

Under our feature flag, Feature.enabled?(:clusters_list_redesign), we have a cluster list that displays node and memory information. This information requires additional api requests and takes longer to load. Also, since we are querying an external Kubernetes cluster, the information may fail to load.

Currently, we display the text Unknown until the nodes have loaded. There is no information given to the customer, letting the customer know the nodes have finished loading.

See related issue: #220319 (closed)

This MR will:

  • Separate cluster loading from node loading using the cluster state
  • Adds gl-skeleton-loading component, to indicate clusters are loading
  • Updates associated tests

Screenshots

Cluster 1 displays node information

Clusters 2 and 3 are invalid nodes. They poll a few times, then display Unknown once the polling has stopped

nodes

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports