Skip to content

Update wording of addMultipleToDiscussionWarning

Jamie Reid requested to merge reword-addMultipleToDiscussionWarning into master

What does this MR do?

The warning dialog that pops when >10 users are added to a discussion can be subject to misinterpretation. "Proceed with caution." may be misinterpreted by a user as a warning about GitLab's ability to handle such an action. To support this belief; the first two hits in google for a search of gitlab "proceed with caution" are entitled "scary warning message".

Our understanding is that the intent of this message is more about ensuring healthy communication practices and providing users a warning that a lot of users may be notified when the action is taken. With that intent in mind, this MR re-words the warning from 'Proceed with caution.' to 'They will all receive a notification.'

This was discussed in !33775 (closed), but I'd improperly hand-edited i18n files in that branch and rather than wrestle with git I chose to start with a clean branch.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jamie Reid

Merge request reports