Skip to content

GitLab Next

    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Menu
    Projects Groups Snippets
  • Sign up now
  • Login
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 43,062
    • Issues 43,062
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,350
    • Merge requests 1,350
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Merge requests
  • !34069

Add cluster reindexing feature to our ES integration

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dmitry Gruzd requested to merge 213629-cluster-reindexing-feature into master Jun 08, 2020
  • Overview 123
  • Commits 9
  • Pipelines 84
  • Changes 16

What does this MR do?

This MR automates steps for the cluster reindexing process gitlab-com/gl-infra/production#2213 (closed)

To schedule a reindexing job you will need to run rake gitlab:elastic:reindex_cluster which will create a ReindexingTask record.

ElasticClusterReindexingCronWorker runs every minute and executes a job with in_progress flag. We can only have 1 job with this flag since we have a unique index.

#213629 (closed)

Reindexing logic/stages

After we create a ReindexingTask it has initial stage

  • initial stage is needed to complete initial checks (i.e. storage requirements) and to enable indexing pause feature. We expect a delay between stages to be enough for existing indexing requests to complete.
  • reindexing stage creates a new index and triggers Elasticsearch reindex API
  • in_progress stage is the polling stage, we're waiting for the task to complete
  • As final stages we have success and failure

Stages graph visualisation

Screenshot_2020-06-29_at_13.09.20

Database changes

This MR introduces a table called reindexing_tasks and ReindexingTask model

Screenshots

Does this MR meet the acceptance criteria?

Conformity

  • Changelog entry
  • Documentation (if required)
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • Database guides
  • Separation of EE specific content

Availability and Testing

  • Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • Tested in all supported browsers
  • Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #213629 (closed)

Edited Sep 28, 2020 by 🤖 GitLab Bot 🤖
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 213629-cluster-reindexing-feature