Skip to content

Add regexp validation on ContainerExpirationPolicy

What does this MR do?

Validates the regular expressions saved within the Container Expiration Policy object. The attributes to be validated are name_regex and name_regex_keep.

For more details, see #216088 (comment 355336634)

With this MR, those columns/attributes are now validated with

validates :name_regex, untrusted_regexp: true
validates :name_regex_keep, untrusted_regexp: true

Screenshots

Screenshot_2020-06-08_at_13.57.42

Screenshot_2020-06-08_at_13.58.01

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by David Fernandez

Merge request reports