Skip to content

Ignore moment.js dependency for pikaday

Vitaly Slobodin requested to merge vs-ignore-moment-dependency-for-pikaday into master

What does this MR do?

Pikaday has a dependency on moment.js but moment.js was removed from our codebase and build outputs an error in the browser's console. Potential fix is to wait when upstream removes moment.js as a direct dependency but Pikaday looks unmaintained (last commit in 2018). Another fix is to add IgnorePlugin from webpack to ignore moment.js when processing Pikaday. That missing dependency also breaks source maps.

Screenshots

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Vitaly Slobodin

Merge request reports