Skip to content

Improve fetching approvals error message

Phil Hughes requested to merge ph/220489/improveApprovalsErrorMessage into master

What does this MR do?

Improves error message when the approvals API request fails. Also added a button to retry the failed API request.

Screenshots

Project settings

Screenshot_2020-06-10_at_12.28.35

Merge request edit/new

Screenshot_2020-06-10_at_12.29.51

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #220489

Edited by Phil Hughes

Merge request reports