Skip to content

Conditionally render gfm metrics

Dhiraj Bodicherla requested to merge conditionally-register-gfm-metrics into master

What does this MR do?

render_metrics.js file loads on all pages, which I believe is correct. However, that also loads the Vuex store from monitoring/stores/embed_group before any other store on a page. Because of this only the embedGroup store and getters are visible on the Vuex chrome developer tools.

This MR changes the embed_group store so that it is initialized when the components/embeds/embed_group.vue component is loaded.

Screenshots

Before After
image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Dhiraj Bodicherla

Merge request reports