Optional enforcement of Personal Access Token expiration
What does this MR do?
Mentions #214723 (closed)
This MR adds a feature for Instance admins to prevent enforcement of Personal Access Tokens expiration automatically.
The Setting is present in the Account and limit section under General Settings.
The feature is available to only Ultimate License.
Behavior
| Application Setting | Feature flag |
|---|---|
enforce_personal_access_token_expiration |
enforce_personal_access_token_expiration |
- When the Setting is disabled, the personal access token of a user does not expire on the Expiry date. In a future MR, we will be showing an in-app message to the user prompting to reset their token.
- When the Setting is enabled, the behavior as same as existing - i.e. the token expires immediately on the expiry date.
- The Setting is enabled by default.
- The Feature flag is disabled by default.
In conjunction with Allowable lifetime for Personal Access Token
- If a max. allowable lifetime for Personal Access Token is defined and the Enforce Personal Access Token expiry Setting is disabled, we do not revoke the access tokens for users immediately as we do currently.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Aishwarya Subramanian