Skip to content

Fix(contribution analytics): tilt x-axis and adjust spacing accordingly

What does this MR do?

This MR makes the x-axis labels tilted/slanted again (as they were originally designed to be) and makes sure there is enough spacing to see the labels as well as making sure the labels aren't cut off. See before/after below:

Screenshots

Before After
Screenshot_2020-06-02_at_14.15.06 Screen_Recording_2020-06-09_at_13.06.41_v3
Firefox Edge Safari
Screenshot_2020-06-10_at_14.45.30 Screenshot_2020-06-10_at_14.44.21 Screenshot_2020-06-10_at_14.45.56

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

These changes add spacing to charts. They should work dynamically but could end up having labels that overlap. I did test it out locally to see if I could trigger such a situation (see gifs above), but was not able to.

These properties also seem locally to these charts, but could become useful for others if needed elsewhere. There is some risk that other developers won't find these options and have to discover them on their own and potentially re-implementing a similar solution instead of re-using this. This risk seems low.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #6830 (closed)

Edited by Michael Lunøe

Merge request reports