Return error when Jira REST request fails
What does this MR do?
When Jira REST request to fetch projects fails, exit early and return the corresponding error.
Issue was reported by @dchevalier2 while running an e2e test, and here is the related error in the logs: https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/jobs/576448884/artifacts/file/gitlab-qa-run-2020-06-02-02-45-26-b48c55b8/gitlab-jira/logs/gitlab-rails/production.log
NoMethodError (undefined method `size' for nil:NilClass):
app/graphql/resolvers/projects/jira_projects_resolver.rb:63:in `jira_projects'
app/graphql/resolvers/projects/jira_projects_resolver.rb:16:in `resolve'
lib/gitlab/graphql/extensions/externally_paginated_array_extension.rb:7:in `resolve'
lib/gitlab/graphql/generic_tracing.rb:40:in `with_labkit_tracing'
lib/gitlab/graphql/generic_tracing.rb:30:in `platform_trace'
lib/gitlab/graphql/generic_tracing.rb:40:in `with_labkit_tracing'
lib/gitlab/graphql/generic_tracing.rb:30:in `platform_trace'
lib/gitlab/graphql/generic_tracing.rb:40:in `with_labkit_tracing'
lib/gitlab/graphql/generic_tracing.rb:30:in `platform_trace'
Screenshots
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mayra Cabrera