Skip to content

Follow-up from "Add "Type" field to asset links on "Edit Release" page

What does this MR do?

The spacing between the form elements in the Links section of the Edit Release page does not comply with the Pajamas guidelines.

Because .row is being used here, the padding/gutter applied is 15px instead of 16px.This MR removes the negative margins from .row and the horizontal padding from all immediate children columns by applying the .no-gutters class, and then apply the correct spacing modifiers to the form groups.

Screenshots

Before After
localhost_3001_root_test-project_-_releases_v2.1_edit_back_url_http_3A_2F_2Flocalhost_3A3001_2Froot_2Ftest-project_2F-2Freleases__2 localhost_3001_root_test-project_-_releases_v2.1_edit_back_url_http_3A_2F_2Flocalhost_3A3001_2Froot_2Ftest-project_2F-2Freleases__1
localhost_3001_root_test-project_-_releases_v2.1_edit_back_url_http_3A_2F_2Flocalhost_3A3001_2Froot_2Ftest-project_2F-2Freleases__3 localhost_3001_root_test-project_-_releases_v2.1_edit_back_url_http_3A_2F_2Flocalhost_3A3001_2Froot_2Ftest-project_2F-_2Freleases

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #219391 (closed)

Edited by Rayana Verissimo

Merge request reports