Geo - Does not try to unlink file when file path is unknown
requested to merge 219993-geo-secondary-tries-to-remove-a-file-indefinitely-when-sync-object-storage-is-enabled into master
What does this MR do?
When cleaning up orphaned registries on a Geo secondary node, there are some cases where it's impossible to unlink the file:
- The replicable record does not exist anymore;
- The replicable file is stored on Object Storage, but the node is not configured to use Object Store;
- Unrecognized replicable type;
For all of them, we should no try to unlink the file.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related issues
Closes #219993 (closed)
Edited by Douglas Barbosa Alexandre