Skip to content

Draft: Eliminate firing an extra count query on GraphQL API

Mehmet Emin INAC requested to merge eliminate_count_query_on_graphql into master

What does this MR do?

While calculating the hasPreviousPage and hasNextPage attribute of the pageInfo we are currently firing a count query to check if there are more records. Instead of firing that count query what we can do is basically fetching one more record from database and then check if we had the extra record in the resultset to determine hasNextPage & hasPreviousPage.

Related to #219186.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Thiago Figueiró

Merge request reports