Skip to content

Make Ci::Minutes::Notification user agnostic

What does this MR do?

Related to #213964 (closed)

Currently Ci::Minutes::Notification holds information about notification levels. We could reuse this class in other aspects of Ci::Minutes if it wasn't for its coupling with current_user in order to display or not a notification.

By removing current_user in Notification, and instead passing it as parameter to show? method, we can reuse it as a ValueObject in other contexts and make it also a SSOT for notification levels.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Thao Yeager

Merge request reports