Skip to content

Use the stream_call method when using the Gitaly Client for querying Diff Stats

Marc Shaw requested to merge 209786-stream-diff-stats-gitaly-call into master

What does this MR do?

Related to #209786 (closed) and #30334 (closed)

While investigating in this MR !33037 (merged), there were some inconsistencies between what our different profiling tools outputted. In the performance bar, it was showing Gitaly having a very low time when we were on a merge request #diffs page, for either the metadata or batches call.

See: Screenshot_2020-06-02_at_12.47.19

However, other profiling tools were showing that the Gitaly time for these two were very high. Switching to the Gitaly client streaming_call method fixes this and shows the correct time taken:

See: Screenshot_2020-06-02_at_12.58.00

I have tracked performance between the two, and there were no noticeable differences.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports