Skip to content

Dynamic loading of emojis from json file

Tim Zallmann requested to merge tz-load-emojis-async into master

What does this MR do?

This is externalising the emojis to load them dynamically from a json file and cache it in localstorage. So that we remove it from the main.js bundle and reduce size.

Screenshots

This will remove this big digests.json part of the main.js bundle (12% reduction):

Bildschirmfoto_2020-07-06_um_15.05.34

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Tim Zallmann

Merge request reports