Skip to content

Change approved to merged in Contribution Analytics

What does this MR do?

Previously Contribution Analytics listed "approved" merge requests, which meant merged. That non-standard terminology was confusing to users, so this changes it to "merged" for clarity, because "merged" is the term used elsewhere in the UI.

This MR was motivated by a conversation in Slack#questions on 2020-05-29:

Cleveland Bledsoe Jr May 29th at 12:21 PM With regards to contribution analytics... For “Accepted MRs” is that the MRs reviewed and approved by an individual? ...

jplum 3 days ago "Accepted MRs" is actual "Merge" button clicks. Approvals are separate.

Note: It is not clear to me why the term "approved" was chosen. Because "merged" seems to be an obvious solution to the problem, I did not invest any time in investigating the choice of "approved".

Screenshots

Screen_Shot_2020-06-01_at_2.10.26_PM

Does this MR meet the acceptance criteria?

Conformity

Edited by Dan Jensen

Merge request reports