Draft: PoC: Implement CI Runner Queueing using Redis-dynamic queues
What does this MR do?
This is PoC of #218640.
It tries to implement all aspects of in a most boring way (not removing complexity).
It does:
- Split
RegisterJobService
to have a separation betweenFiltering
andAssign
- Introduces
Ci::Queueing::Params
a set ofParams
that needs to be used by Filtering - Moves most of
RegisterJobService
intoLegacyDatabaseMethod
- Adds a new
RedisDatabaseMethod
that performs a cheap pop from the Redis, or schedules async job to update a dynamic queue - Ensures that
register job service
tests are tested against two methods and are green - IT DOES NOT CHANGE ANY TODAYS LOGIC, just moves things around
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Kamil Trzciński