Skip to content

Draft: PoC: Implement CI Runner Queueing using Redis-dynamic queues

Kamil Trzciński requested to merge ci-runner-queueing into master

What does this MR do?

This is PoC of #218640.

It tries to implement all aspects of in a most boring way (not removing complexity).

It does:

  • Split RegisterJobService to have a separation between Filtering and Assign
  • Introduces Ci::Queueing::Params a set of Params that needs to be used by Filtering
  • Moves most of RegisterJobService into LegacyDatabaseMethod
  • Adds a new RedisDatabaseMethod that performs a cheap pop from the Redis, or schedules async job to update a dynamic queue
  • Ensures that register job service tests are tested against two methods and are green
  • IT DOES NOT CHANGE ANY TODAYS LOGIC, just moves things around

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kamil Trzciński

Merge request reports