Remove locally defined RSpec/EmptyLineAfterSharedExample
What does this MR do?
Removes the locally defined cop in favor of the upstreamed version provided by gitlab-styles
gem.
Validated Cop is working as expected by temporarily creating an exception...
10:35 $ be rubocop spec/lib/banzai/filter/video_link_filter_spec.rb
Inspecting 1 file
C
Offenses:
spec/lib/banzai/filter/video_link_filter_spec.rb:60:7: C: RSpec/EmptyLineAfterSharedExample: Add an empty line after it_behaves_like block.
end
^^^
1 file inspected, 1 offense detected
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #218442
Edited by Doug Stull