Skip to content

Resolve "Group members domain allow-list should allow multiple domains"

What does this MR do?

Changes for #33143 (closed)

Changes:

  • For a group, allows to specify multiple email domains in a comma-separated fashion via the Group settings UI:

Screenshot_2020-06-03_at_10.00.26_AM

Effects

  • Inviting a new user to this group fails when the user's email does not match at-least one of the allowed domains:

Screenshot_2020-06-02_at_11.32.06_AM

  • Adding existing users in the instance to this group fails, when the user's email does not match at-least one of the allowed domains:

Screenshot_2020-06-02_at_11.31.48_AM

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Craig Norris

Merge request reports