Skip to content

Geo Package Files - Initialize

Zack Cuddy requested to merge 208470_01-package-file-hookup into master

What does this MR do?

This MR splits off from !32872 (closed)

This MR is an attempt at MVC to avoid the above massive MR going in all at once.

This MR focuses on creating the entry point for Geo Replication - Package Files. To do so, we need a Rails Controller, View, and Route. Then we also need the entry point for the JavaScript hook.

The UI navigational elements are hidden behind the feature flag geo_self_service_framework

No endpoints have been hooked up, so no data will come back (yet)

The Vue component is generalized, and is able to render the elements based on the key package_files. This item is 2 words separated by an _, which exposed a minor UI bug that required the string to be split on the _ for readability.

What is still left to implement as part of this MVC

  1. GraphQL actions and endpoint for the Vuex Store.
  2. Add some conditionals to support the Package Files fully in the UI
  3. Add the GraphQL based pagination

Important Notes

A lot of this code will be replaced in the future by more generalization. More can be read about that as part of the Generalization section of &2525

Screenshots

UI
w/o feature flag Feature_Disabled
w/ feature flag Feature_Enabled

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Zack Cuddy

Merge request reports