Skip to content

Allow blank external_dashboard_url

Ryan Cobb requested to merge rc/allow_blank_dashboard_url into master

What does this MR do?

Note: This is currently pointed at rc/add_dashboard_timezone. Once that is merged this will be pointed at master

Part of #214370 (closed), also addresses #220210 (closed)

!33120 (merged) removed the database not null constraint. This MR removes the application not null constraint. This is needed since we added a new field dashboard_timezone and users will have cases where they update dashboard_timezone while still leaving external_dashboard_url blank.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading